gosmee: init at 0.21.0 #284789
Merged
gosmee: init at 0.21.0 #284789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
add-gosmee
branch
from
1b940bc
to
d9a0dcf
Compare
ofborg
bot
added
11.by: package-maintainer
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3492 |
SuperSandro2000
requested changes
Feb 22, 2024
vdemeester
force-pushed
the
add-gosmee
branch
from
d9a0dcf
to
b0edd5a
Compare
|
@SuperSandro2000 updated, thanks for the review 👼🏼 |
SuperSandro2000
requested changes
Mar 7, 2024
wegank
added
the
2.status: merge conflict
|
Could we get this into NixOS 24.05? It would be really helpful since the npm module is not in nixpkgs either. |
SuperSandro2000
approved these changes
May 17, 2024
SuperSandro2000
force-pushed
the
add-gosmee
branch
from
6ac0961
to
6bd03bf
Compare
SuperSandro2000
approved these changes
May 17, 2024
github-actions
bot
added
8.has: maintainer-list (update)
ofborg
bot
removed
the
2.status: merge conflict
pkgs/by-name/go/gosmee/package.nix
Outdated
| nativeBuildInputs = [ installShellFiles ]; | ||
|
|
||
| postPatch = '' | ||
| printf ${version} > $sourceRoot/gosmee/templates/version |
There was a problem hiding this comment.
Suggested change
| printf ${version} > $sourceRoot/gosmee/templates/version | |
| mkdir -p $sourceRoot/gosmee/templates | |
| printf ${version} > $sourceRoot/gosmee/templates/version |
source root is source
Running phase: patchPhase
/nix/store/wq046wv3s3h4m2n9ak3j534di2pzra93-stdenv-linux/setup: line 114: source/gosmee/templates/version: No such file or directory
/nix/store/wq046wv3s3h4m2n9ak3j534di2pzra93-stdenv-linux/setup: line 131: pop_var_context: head of shell_variables not a function context
error: builder for '/nix/store/l759i5krlyliwbk7lr0jdg3cj4qn0rnf-gosmee-0.21.0.drv' failed with exit code 1;
There was a problem hiding this comment.
in postPatch, PWD already points to /build/source and sourceRoot points to source, so it fails anyway.
Signed-off-by: Vincent Demeester <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a new package,
gosmeeto nixpkgs.This also adds @chmouel as a maintainer of this package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.